JDK-8255670 : Improve C2's detection of modified nodes
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: 16
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2020-10-30
  • Updated: 2022-09-29
  • Resolved: 2022-09-22
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 20
20 b17Fixed
Related Reports
Blocks :  
JDK-8293362 - Extend detection of modified nodes to incremental inlining
Relates :  
JDK-8255665 - C2 should aggressively remove temporary hook nodes
Relates :  
JDK-8040213 - C2 does not put all modified nodes on IGVN worklist
Description
JDK-8040213 added detection of modified nodes that are not re-processed by IGVN. This logic should be extended to also cover Node::clone, Node::add_req, Node::add_req_batch, Node::ins_req, Node::add_prec, Node::set_prec, Node::rm_prec.

In a second step JDK-8293362, we want to extend the detection to incremental inlining.
Comments
Changeset: 83abfa5d Author: Emanuel Peter <epeter@openjdk.org> Date: 2022-09-22 07:44:50 +0000 URL: https://git.openjdk.org/jdk/commit/83abfa5d8231d5bfa383989159758cbe3530ee51
22-09-2022
A pull request was submitted for review. URL: https://git.openjdk.org/jdk/pull/9439 Date: 2022-07-09 08:37:24 +0000
12-09-2022
Node::raw_del_out It does not seem to make sense to track this, as it only modifies output, and IGVN does not look at outputs when processing nodes.
24-06-2022
The code in Compile::process_late_inline_calls_no_inline explicitly disables verification of modified nodes. That should be fixed as well once we support incremental inlining.
03-09-2021