Bug ID: JDK-8040213 C2 does not put all modified nodes on IGVN worklist

JDK-8040213 : C2 does not put all modified nodes on IGVN worklist

Type: Bug
Component: hotspot
Sub-Component: compiler
Affected Version: 9

Priority: P4
Status: Resolved
Resolution: Fixed
OS: generic
CPU: generic

Submitted: 2014-04-15
Updated: 2020-10-30
Resolved: 2014-07-25

Versions (Unresolved/Resolved/Fixed)

The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.

JDK 9
9 b28Fixed

Related Reports

Duplicate :	JDK-8005067 - IGVN transformations don't always properly handle nodes that get disconnected
Relates :	JDK-8086057 - Crash with "modified node is not on IGVN._worklist" when running with -XX:-SplitIfBlocks
Relates :	JDK-8039050 - Crash in C2 compiler at Node::rematerialize
Relates :	JDK-8255665 - C2 should aggressively remove temporary hook nodes
Relates :	JDK-8053915 - bigapps assert failure in C2: modified node is not on IGVN._worklist
Relates :	JDK-8255670 - Improve C2's detection of modified nodes
Relates :	JDK-8054081 - Crashes with assert "modified node is not on IGVN._worklist"

Description

Not all nodes are put on IGVN worklist when their inputs are modified (for example in loop opts).
As result we may get bad graph because data and control paths are inconsistent.

Comments

ILW=Potential problem, low, none = MLH=P4

22-04-2014

I added verification code and spent few days trying to clean up C2 code but still not finished: http://cr.openjdk.java.net/~kvn/8040213/webrev/ In general we should use igvn.replace_input_of() and igvn.rehash_node_delayed() during Optimize. These methods put nodes on igvn worklist.

15-04-2014