JDK-8293362 : Extend detection of modified nodes to incremental inlining
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: 20
  • Priority: P4
  • Status: Open
  • Resolution: Unresolved
  • Submitted: 2022-09-05
  • Updated: 2022-12-16
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
tbdUnresolved
Related Reports
Blocks :  
JDK-8255670 - Improve C2's detection of modified nodes
Relates :  
JDK-8298951 - Umbrella: improve CCP and IGVN verification
Description
In JDK-8255670 we extended the assertion code to include all modifications to nodes, and check that they are processed in igvn.

So far, incremental inlining is explicitly excluded from this check. The goal is to include it.

I tried this before, and got a lot of failure cases, with all sorts of nodes. If I remember correctly, we use GraphKit to generate new nodes during regular parsing, but also during late/incremental inlining. But somehow they now only trigger the assert in the late/incremental inlining case. It cannot be that in all those cases we explicitly add the node to igvn worklist, so you need to find another solution that is more general.