JDK-8168611 : Backport various Ensemble8 fixes from FX 9 to FX 8
  • Type: Task
  • Component: javafx
  • Sub-Component: samples
  • Affected Version: 8u152
  • Priority: P2
  • Status: Closed
  • Resolution: Fixed
  • Submitted: 2016-10-24
  • Updated: 2017-09-27
  • Resolved: 2016-10-26
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 8
8u152 b01Fixed
Related Reports
Blocks :  
JDK-8142439 - Ensemble8 media player slider issues
Blocks :  
JDK-8152858 - Ensemble Timeline regression
Blocks :  
JDK-8160020 - Replace obsolete JavaFX applications on OTN with Ensemble8
Blocks :  
JDK-8165373 - Ensemble8 uses setAccessible to access methods and fields of various classes
Blocks :  
JDK-8091485 - Ensemble8: Review each sample description, playground, appearance, related docs and links
Blocks :  
JDK-8168095 - Second image in Ensemble8/Image Creation sample does not load
Blocks :  
JDK-8134354 - Ensemble Media samples sliders don't react to clicks
Blocks :  
JDK-8136968 - [Mac] Regression from JDK-8087709
Blocks :  
JDK-8136918 - Ensemble uses deprecated flv (vp6) media files hosted on OTN
Description
This is an umbrella task to track the backports of various Ensemble8 fixes from FX 9 to FX 8.

As described in JDK-8160020, we need to replace the old Ensemble2 demo on OTN with Ensemble8. We further need to compile Ensemble8 with JDK 8u so that it will run on both JDK 8u and JDK 9. In support of this, I propose to backport 12 bugs from FX 9 to FX 8u-dev (as 12 separate changesets, one for each bug) so the version we deploy on OTN will have all of the needed bug fixes.
Comments
Verified the 12 backport fixes onto 8u152.
27-09-2017
+1
25-10-2016
+1
25-10-2016
I am posting both a combined (aggregate) webrev as well as 12 separate webrevs. If you want to apply and test the patch you might find it easier to use the combined webrev. If you want to code review the changes, you might prefer the separate webrevs. Combined webrev: http://cr.openjdk.java.net/~kcr/Ensemble8/combined/webrev/ Separate webrevs: http://cr.openjdk.java.net/~kcr/Ensemble8/separate/ The only large webrev is #4 -- JDK-8091485 -- which was a cleanup bug that fixed a variety of small issues with the description, playground, appearance, related docs and links for each sample in Ensemble8 ------------- The methodology I used to apply the webrevs was: 1. 'hg export' all 12 patches from FX 9-dev/rt in the order listed above. 2. in 8u-dev/rt do (roughly) the following: for each patch in $patches; do hg qimport $patch hg qpush [fix up white space, copyright, author] done 3. JDK-8091485 had a fairly trivial conflict due to an unrelated change that was applied in 8u-dev and missed in 9 (later pushed to 9, but in a different order relative to the conflicting changeset). 4. The patches for the first two bugs -- JDK-8134354 and JDK-8136968 -- were pushed to 9 with the wrong bug ID. I noted this in those JBS issues and fixed them in their backports. After applying all 12 patches I built and tested Ensemble8 and all looks good. I also ran a diff between the patched 8u-dev and 9-dev and they are now identical except for one file. There was a Hi-DPI change that touched src/app/java/ensemble/control/Popover.java as part of JDK-8091832. We can deal with that separately from this umbrella backport task; if we decide that it's the right thing to do, we can take just the change to that one file, altering the backport to continue using the deprecated snapSize rather than the new-in-9 snapSizeX.
24-10-2016
Here is a list of the 12 Ensemble8 bugs that need to be backported to FX 8u, in order from oldest changeset to newest changeset: JDK-8134354 : Ensemble Media samples sliders don't react to clicks JDK-8136968 : [Mac] Regression from JDK-8087709 JDK-8142439 : Ensemble8 media player slider issues JDK-8091485 : Ensemble8: Review each sample description, playground, appearance, related docs and links JDK-8152858 : Ensemble Timeline regression JDK-8136918 : Ensemble uses deprecated flv (vp6) media files hosted on OTN JDK-8087648 : We can not see any radio buttons in Node Properties demo JDK-8154764 : The negative values in the list are not enclosed in parentheses JDK-8154579 : Pagination demo:thrown java.lang.IllegalArgumentException on console, when clicking the link of "VIEW SOURCE" JDK-8088078 : [Chart] ���Insert Series��� can not work as expected after we remove all data JDK-8165373 : Ensemble8 uses setAccessible to access methods and fields of various classes JDK-8168095 : Second image in Ensemble8/Image Creation sample does not load
24-10-2016