Bug ID: JDK-8134354 Ensemble Media samples sliders don't react to clicks

Versions (Unresolved/Resolved/Fixed)

The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.

JDK 8	JDK 9
8u152Fixed	9Fixed

Open any media sample, try to seek or change the volume by clicking on the slider, not on the thumb.
The thumb momentarily jumps to the point of click then goes back.
This happens because all slider value change listeners do actual work inside this condition:
if (timeSlider.isValueChanging()) {
which means that it only reacts to the thumb drag.

Webrev for 8u backport: http://cr.openjdk.java.net/~kcr/Ensemble8/separate/01-8134354/webrev/
24-10-2016
This is part of an aggregate backport request to port Ensemble8 fixes from FX 9 to FX 8u. See JDK-8168611 for details and review.
24-10-2016
NOTE: the bug ID in the changeset comment is incorrect. It should have been 8134354 (not 8134353). This should be fixed for the backport.
20-10-2016
@Vadim: can you file a new follow-on bug since the changeset for this was already pushed?
05-10-2015
Moreover, Advanced Media doesn't react to changes made by sliders while the video is stopped.
05-10-2015
It seems that the Advanced Media sample wasn't fixed...
05-10-2015
Another thing I noticed is that in PlayerPane in the timeSlider.valueProperty() in the added else clause the updateValues() call is missing. Perhaps it could be changed as if (timeSlider.isValueChanging() \|\| Math.abs(now.doubleValue() - old.doubleValue()) > 1.5) { ... ?
23-09-2015
Morris, Could these ifs just be deleted? if (volumeSlider.isValueChanging()) { mp.setVolume(volumeSlider.getValue() / 100.0); } else { mp.setVolume(volumeSlider.getValue() / 100.0); }
22-09-2015
Fixed in 9-dev with this change set: Changeset: 222d8f8a82c6 Author: Morris Meyer <morris.meyer@oracle.com> Date: 2015-09-22 13:51 -0400 URL: http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/222d8f8a82c6 8134353: [Mac] Ensemble Media samples sliders don't react to clicks Reviewed-by: kcr ! apps/samples/Ensemble8/src/samples/java/ensemble/samples/media/overlaymediaplayer/OverlayMediaPlayerApp.java ! apps/samples/Ensemble8/src/samples/java/ensemble/samples/media/overlaymediaplayer/PlayerPane.java ! apps/samples/Ensemble8/src/samples/java/ensemble/samples/media/streamingmediaplayer/PlayerPane.java ! apps/samples/Ensemble8/src/samples/java/ensemble/samples/media/streamingmediaplayer/StreamingMediaPlayerApp.java
22-09-2015

Blocks :	JDK-8168611 - Backport various Ensemble8 fixes from FX 9 to FX 8
Relates :	JDK-8142439 - Ensemble8 media player slider issues