JDK-8339170 : ☂ Convert tests to JUnit 5
  • Type: Task
  • Component: javafx
  • Sub-Component: other
  • Priority: P4
  • Status: Open
  • Resolution: Unresolved
  • Submitted: 2024-08-28
  • Updated: 2025-04-11
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
tbdUnresolved
Related Reports
Blocks :  
JDK-8338468 - [TestBug] Convert controls tests to JUnit 5
Blocks :  
JDK-8339510 - [TestBug] Convert system tests to JUnit 5
Blocks :  
JDK-8339511 - [TestBug] Convert Non parametrized base tests to JUnit 5
Blocks :  
JDK-8339512 - [TestBug] Convert graphics tests to JUnit 5
Blocks :  
JDK-8354455 - [TestBug] Remove JUnit Vintage Engine with JUnit 4
Blocks :  
JDK-8339515 - [TestBug] Convert web tests to JUnit 5
Blocks :  
JDK-8340464 - [TestBug] Convert parametrized base tests to JUnit 5
Blocks :  
JDK-8339514 - [TestBug] Convert swing tests to JUnit 5
Blocks :  
JDK-8339513 - [TestBug] Convert fxml tests to JUnit 5
Relates :  
JDK-8328629 - JUnit test without a timeout value can hang indefinitely
Relates :  
JDK-8296284 - Update CONTRIBUTING guidelines to state that JUnit 5 is used for tests
Description
This is an umbrella task. The actual work will be done in linked blocking bugs.

These notes might help the migration process:
https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
Comments
[~mhanl] Thank you for linking the bug tracking the remaining JUnit4 tests. Progress on that bug has stopped for now, and we will likely take it up for our next test sprint (in March) unless someone wants to take it before then (if so, ask Jay first). The two follow-on steps that you mentioned would be a good thing to do once that is done.
25-11-2024
There seems to be around ~44 files left that contain JUnit4 imports (most of them in javafx.base). Is there any plan to remove those as well? If yes, I can create an issue and also the corresponding PR. EDIT: I was too fast, just found the issue for javafx.base, it was not linked here. I did that now! Good to see that it is worked on. Then we can remove JUnit4 and the JUnit Vintage Engine dependency completely. And then we can update the guidelines, that we use JUnit5 (and thats it, since mixing the imports is not possible anymore).
24-11-2024