JDK-8296284 : Update CONTRIBUTING guidelines to state that JUnit 5 is used for tests
  • Type: Bug
  • Component: javafx
  • Sub-Component: other
  • Affected Version: jfx20
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2022-11-03
  • Updated: 2025-06-26
  • Resolved: 2025-06-21
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
jfx25 b22Fixed
Related Reports
Relates :  
JDK-8296283 - JUnit5 tests using Params API fails to compile
Relates :  
JDK-8339170 - ☂ Convert tests to JUnit 5
Description
We do not mix JUnit4 and JUnit5 API in same test class. This should be updated in the jfx CONTRIBUTING guidelines.
Comments
Changeset: 3836b96b Branch: master Author: Marius Hanl <mhanl@openjdk.org> Date: 2025-06-21 19:42:13 +0000 URL: https://git.openjdk.org/jfx/commit/3836b96b1ac676c49eb0fb9d1f08715433710590
21-06-2025
A pull request was submitted for review. Branch: master URL: https://git.openjdk.org/jfx/pull/1828 Date: 2025-06-14 11:37:30 +0000
14-06-2025
JDK-8340464 is tracking the last remaining conversion to JUnit 5, and is targeted for this test sprint. So for this bug, we should modify the CONTRIBUTING guidelines to state that JUnit 5 should be used for all tests.
21-03-2025
I think we should do this for the upcoming test sprint, especially since we plan to start converting our existing tests to JUnit5. Additionally, the advice should be to use JUnit 5 for all new tests, unless you are extending a base class that still uses JUnit 4.
03-09-2024