JDK-8231601 : Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes
  • Type: Enhancement
  • Component: javafx
  • Sub-Component: other
  • Affected Version: openjfx14
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2019-09-28
  • Updated: 2021-12-21
  • Resolved: 2021-12-18
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
openjfx18Fixed
Related Reports
Duplicate :  
JDK-8278927 - update Contributing for issue closing
Duplicate :  
JDK-8231722 - Contributing.md should direct to the mailing lists
Relates :  
JDK-8231327 - Update JavaFX Code Review Wiki page
Description
The documented policies for contributing new features to JavaFX could be made more clear, specifically the need to discuss API changes on the mailing list before working on it. The following PR included a meta-discussion that prompted this desired process improvement:

https://github.com/javafxports/openjdk-jfx/pull/499

I wrote up some notes here that can be used as the basis for updating the policies:

https://github.com/kevinrushforth/openjdk-jfx/blob/notes/doc-files/kcr/new-features.md

Additionally, we need to make changes in the contributing guide to align with recent (and not-so-recent) changes in the Skara tooling. For example:

* The Skara bot cross-links the PR and JBS issue, so need not be done manually
* The Skara bot automatically resolves the JBS issue when the PR is integrated, so need not be done manually
* We can suggest the use of the "/reviewers 2" and "/csr" commands.
Comments
Changeset: 18063ade Author: Kevin Rushforth <kcr@openjdk.org> Date: 2021-12-18 00:05:37 +0000 URL: https://git.openjdk.java.net/jfx/commit/18063ade22defdf55ec1b2083a5b296422ed05f4
18-12-2021
Here are a couple other improvements to consider: * Add a note about title of PR matching exactly the JBS title (Skara tooling will highlight it if you don't, so this would be a reminder for contributors and reviewers to check for it) * Add a note to avoid unrelated changes when fixing a bug. See this comment: https://github.com/openjdk/jfx/pull/167#issuecomment-615894845
14-09-2020
See JDK-8231722 for additional information.
17-12-2019