JDK-8231327 : Update JavaFX Code Review Wiki page
  • Type: Task
  • Component: javafx
  • Sub-Component: other
  • Affected Version: internal
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2019-09-21
  • Updated: 2019-10-01
  • Resolved: 2019-10-01
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
internalFixed
Related Reports
Blocks :  
JDK-8231325 - ��� Switch official FX mainline repo to GitHub using Skara tooling
Relates :  
JDK-8231601 - Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes
Relates :  
JDK-8231326 - Update README and CONTRIBUTING docs for Skara
Description
The code review policies and procedures are defined on the following Wiki:

https://wiki.openjdk.java.net/display/OpenJFX/Code+Reviews

The process around the mechanics of reviewing changes needs to be updated for moving the official repo is to GitHub and using the Skara tooling.
Comments
To review the planned changes, I created a Wiki page with an updated Code Review section here: https://wiki.openjdk.java.net/display/OpenJFX/%28DRAFT%29+Code+Reviews You can see the diffs between the existing section and the new section by clicking here: https://wiki.openjdk.java.net/pages/diffpagesbyversion.action?pageId=51282115&selectedPageVersions=9&selectedPageVersions=1 The main difference was to remove the reference to the GitHub sandbox and to indicate that reviews are now always done via a pull request against the https://github/openjdk/jfx repo.
28-09-2019
I filed JDK-8231601 to track the issue of clarifying the process of adding new features to JavaFX.
28-09-2019
The above mentioned changes to the new features section are independent from the Skara changes and warrant a separate review. I will file a follow-on issue to track addressing those changes. That way we will not delay review of the Skara changes.
24-09-2019
As long as I am changing this, I will consider incorporating the notes from: https://github.com/kevinrushforth/openjdk-jfx/blob/notes/doc-files/kcr/new-features.md
21-09-2019
This should be done after the HG repo is made read-only and before the new GitHub repo is open for pull requests.
21-09-2019