JDK-8202762 : Move HotSpot-AOT packages to upstream Graal repo
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: 11
  • Priority: P3
  • Status: Closed
  • Resolution: Duplicate
  • Submitted: 2018-05-08
  • Updated: 2019-01-15
  • Resolved: 2018-09-04
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
tbdResolved
Related Reports
Blocks :  
Duplicate :  
Description
To simplify development and merges it'd be great to move all packages under jdk/open/src/jdk.aot/share/classes to upstream Graal repo. That should allow us:
1. Add unit tests for aot that would be run in graal gate to ensure there is no breakage to aot as early in the repo hierarchy as possible.
2. Simplify the development process by allowing to use the Graal repo as a base for development. This will also simplify merges in the presence of renaming.

The result of the move should include an mx command to run aot, and include the aot packages in the updategraalinopenjdk mx command which should land them in jdk/open/src/jdk.aot/share/classes.
Comments
The minimum Java version needed for an mx project is expressed via the javaCompliance attribute (e.g. https://github.com/oracle/graal/blob/master/compiler/mx.compiler/suite.py#L144 ).
09-05-2018

It's not very urgent, but it's a good investment. In presence of renaming during Graal updates this will greatly simplify the life of people working on AOT. Essentially it would allow working on AOT using the vanilla Graal repo, without copying things around. Regarding other questions: I don't think AOT packages should be build for JDKs < 9. The runtime support for AOT is only since 9, so testing on 8 will not be possible anyway. Building the source also depends on having the jigsaw APIs. I'm not quite sure how to express the version requirement in mx, perhaps [~dnsimon] can give us a hint.
09-05-2018

How urgent is this? Does it need to be done by JDK 11? Are there any issues with the graal repository being built for targets less than JDK 11? Do the aot source have any Java language dependency on JDK 10 or 11?
09-05-2018