JDK-8169555 : Need unit tests for JDK-8169289
  • Type: Bug
  • Component: javafx
  • Sub-Component: application-lifecycle
  • Affected Version: 9
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Submitted: 2016-11-10
  • Updated: 2017-04-06
  • Resolved: 2017-04-06
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 9
9Fixed
Related Reports
Relates :  
JDK-8169289 - JavaFX application in named module fails to launch if no main method
Relates :  
JDK-8177751 - Update FX implementation to prepare for renaming of Module and Layer classes
Description
The changes for JDK-8169289 are split between JDK and OpenJFX, so unit tests need to be delayed until we get a promotion that has all associated changes.
Comments
Changeset: f5a72d3a92a0 Author: kcr Date: 2017-04-06 08:20 -0700 URL: http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/f5a72d3a92a0 8169555: Need unit tests for JDK-8169289 Reviewed-by: ddehaven, ddhill
06-04-2017
+1 still
06-04-2017
That looks fine to me.
06-04-2017
Was doing some last minute checking and realized that I missed adding the following lines (from MainLauncherTest) to ModuleLauncherTest, to print more sensible error messages for these two failures (if they ever were to occur). diff --git a/tests/system/src/test/java/test/launchertest/ModuleLauncherTest.java b/tests/system/src/test/java/test/launchertest/ModuleLauncherTest.java --- a/tests/system/src/test/java/test/launchertest/ModuleLauncherTest.java +++ b/tests/system/src/test/java/test/launchertest/ModuleLauncherTest.java @@ -73,6 +73,13 @@ throw new AssertionFailedError(testAppName + ": unable to launch java application"); + case ERROR_TOOLKIT_NOT_RUNNING: + throw new AssertionFailedError(testAppName + + ": Toolkit not running prior to loading application class"); + case ERROR_TOOLKIT_IS_RUNNING: + throw new AssertionFailedError(testAppName + + ": Toolkit is running but should not be"); + case ERROR_UNEXPECTED_EXCEPTION: throw new AssertionFailedError(testAppName + ": unexpected exception"); Any concerns with my adding this before I push?
06-04-2017
learned a bit more about module-source-path, did not realize they allowed for a simpler version (which makes sense to me) +1
06-04-2017
Looks good to me: +1
06-04-2017
Webrev: http://cr.openjdk.java.net/~kcr/8169555/webrev.00/
05-04-2017
The recent fix for JDK-8177751 also highlighted the need for this test. While verifying that fix, I noticed that we have no tests that verify whether we can launch a modular application (launchMode = LM_MODULE) so I had to manually verify it using the test application from JDK-8169289. I note that when the fix for JDK-8169289 was pushed we didn't have a framework to allow such a test to be added, but now we do.
05-04-2017