JDK-8134764 : Refactor Javafx controls module tests for clear separation of tests
Type:Bug
Component:javafx
Sub-Component:controls
Affected Version:9
Priority:P3
Status:Resolved
Resolution:Fixed
Submitted:2015-08-31
Updated:2015-09-18
Resolved:2015-09-18
The Version table provides details related to the release that this issue/RFE will be addressed.
Unresolved : Release in which this issue/RFE will be addressed. Resolved: Release in which this issue/RFE has been resolved. Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.
After the requested reverts:
Changeset: d015af1e73c5
Author: ddhill
Date: 2015-09-18 09:09 -0400
URL: http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/d015af1e73c5
8134764: Refactor Javafx controls module tests for clear separation of tests
Reviewed-by: kcr, jgiles
18-09-2015
+1 after reverting the three unintended changes.
17-09-2015
Based on what Jonathan found, I went looking for files which should not have been changed and found these:
M modules/controls/src/main/java/javafx/scene/control/Cell.java
M modules/controls/src/main/java/javafx/scene/control/TreeView.java
M modules/controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
All three should be reverted.
17-09-2015
+1
17-09-2015
I'll just post this URL with no further comment :-)
http://cr.openjdk.java.net/~ddhill/8134764/modules/controls/src/main/java/javafx/scene/control/Cell.java.sdiff.html
17-09-2015
Webrev: http://cr.openjdk.java.net/~ddhill/8134764
This the controls refactor that goes with the base and graphics that went before it. The goal is to separate out the JUnit tests to be on the right classloader so they will work with Jigsaw.