JDK-8134762 : Refactor Javafx graphics module tests for clear separation of tests
  • Type: Bug
  • Component: javafx
  • Sub-Component: graphics
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2015-08-31
  • Updated: 2015-09-15
  • Resolved: 2015-09-15
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 9
9Fixed
Related Reports
Blocks :  
Blocks :  
Blocks :  
Description

The JavaFX unit tests have relied on a "mixed" class path for testing, needing to run on the application classpath to access Junit as well the test classes. This is not how Javafx runs in normal circumstances, as it is normally on the extension class loader.

We need to refactor these test:
    the "white box", classes that must reside in certain classes for protected class access
    the "black box": classes that can operate from outside the javafx package structure

This will require adding some "shims" in the white box, to allow the black box tests to operate.
All Junit tests must be in the black box.

All black box tests will be refactored into a package tests.*

This refactoring affects modularization efforts in JDK 9 
Comments
Changeset: 73c9533410b0 Author: ddhill Date: 2015-09-15 14:35 -0400 URL: http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/73c9533410b0 8134762: Refactor Javafx graphics module tests for clear separation of tests Reviewed-by: kcr
15-09-2015

Looks good. +1
15-09-2015

Note, the entire contents of the graphics module tests were refactored to be under package test. This means there is a lot of new/removed files showing. Files called *Shim.java are the new classes Webrev: http://cr.openjdk.java.net/~ddhill/8134762/
14-09-2015