JDK-8370499 : [lworld] Back fill unit tests for jimage and ImageReader
  • Type: Sub-task
  • Component: tools
  • Sub-Component: jlink
  • Priority: P4
  • Status: Closed
  • Resolution: Withdrawn
  • Submitted: 2025-10-23
  • Updated: 2025-12-18
  • Resolved: 2025-12-18
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
repo-valhallaResolved
Description
Once preview mode support for ImageReader and jimage is present, and once the jimage writer code can correctly create the new jimage with preview resources, new unit tests for both ImageReader and jimage should be added.

Currently, the plan for this work is to submit in parts, such that generating the jimage with preview resources comes after including the code to support it. This makes it impossible to submit the unit test changes for jimage.cpp and ImageReader.java as they are submitted.

These tests could go into the image writer changes, but I think it's better if they go in as a more focused change immediately after that's in.
Comments
The testing of ImageReader and ExplodedImage is now done via common tests for SystemImage. While there is some room for tidying up the duplicate unit tests still in ImageReader now, it's not part of "backfilling" anything. At this point I'm happy that the test coverage of ImageReader, ExplodedImage and SystemImage (esp. for preview mode) is good enough.
18-12-2025
Unit tests already written/passing, so just need to be pulled into a PR.
23-10-2025