Bug ID: JDK-8364822 Comment cleanup, stale references to closeDescriptors and UNIXProcess.c

Versions (Unresolved/Resolved/Fixed)

The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.

JDK 26
26 b11Fixed

There are some stale comment references, searching for closeDescriptors:

src/hotspot/os/aix/os_aix.cpp:  // appropriate file descriptors (e.g. as we do in closeDescriptors in
src/hotspot/os/bsd/os_bsd.cpp:  // appropriate file descriptors (e.g. as we do in closeDescriptors in
src/hotspot/os/linux/os_linux.cpp:  // (e.g. as we do in closeDescriptors in UNIXProcess.c), and this in
src/java.base/unix/native/libjava/childproc.c:       Closing pipe fds here is redundant, since closeDescriptors()


Since:
8210549: Runtime.exec: in closeDescriptors(), use FD_CLOEXEC instead of close()

in src/java.base/unix/native/libjava/childproc.c

closeDesciptors was renamed:

-closeDescriptors(void)
+markDescriptorsCloseOnExec(void)


(Noticed while reviewing JDK-8364312.)

UNIXProcess.c reference not related to 8210549.  May relate to what was previously jdk/src/solaris/native/java/lang/UNIXProcess_md.c may mean the current  ./src/java.base/unix/native/libjava/ProcessImpl_md.c

Changeset: 83953c45 Branch: master Author: Guanqiang Han <ghan@openjdk.org> Committer: Kevin Walls <kevinw@openjdk.org> Date: 2025-08-07 14:11:46 +0000 URL: https://git.openjdk.org/jdk/commit/83953c458eb65b2af184340dd460325f2b56e5b9

07-08-2025

A pull request was submitted for review. Branch: master URL: https://git.openjdk.org/jdk/pull/26667 Date: 2025-08-07 01:49:41 +0000

07-08-2025