Bug ID: JDK-8361259 JDK25: Backout JDK-8258229

Versions (Unresolved/Resolved/Fixed)

The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.

JDK 25
25 b30Fixed

JDK-8258229 has caused VM crashes. See JDK-8357017 for example.
The change is incorrect for non-x86 platforms. They don't use a runtime_call for not-entrant patching at the verified entry point (VEP).

In addition, there were concerns about the usage of NMethodState_lock. See Dean's comment in JDK-8357017:
"This is a tricky one. I'm not really happy with the JDK-8258229 changes. It solves the problem with print_nmethod by grabbing the NMethodState_lock. This means make_not_entrant and other code that uses NMethodState_lock might block for a long time waiting for tty output. But the bigger problem is all the other uses of RelocIterator that are still susceptible to this race. I don't think we want to add NMethodState_lock to all those places."

JDK-8358821 (in jdk26) is a better fix which doesn't have these drawbacks. We should probably backport that one to jdk25u after an appropriate stabilization time.

I think that JDK-8258229 is not a critical issue and we can postpone fixing it by one or two jdk25u releases.

ILW = same as JDK-8357017 = P3

04-07-2025

Changeset: 993215f3 Branch: jdk25 Author: Martin Doerr <mdoerr@openjdk.org> Date: 2025-07-03 08:52:23 +0000 URL: https://git.openjdk.org/jdk/commit/993215f3dd7aba221da8c901117a8ff3f0ccb675

03-07-2025

A pull request was submitted for review. Branch: jdk25 URL: https://git.openjdk.org/jdk/pull/26091 Date: 2025-07-02 10:54:13 +0000

02-07-2025

Relates :	JDK-8358821 - patch_verified_entry causes problems, use nmethod entry barriers instead
Relates :	JDK-8258229 - Crash in nmethod::reloc_string_for
Relates :	JDK-8357017 - UnexpectedDeoptimizationAllTest.java crashes in C1 during nmethod registration