JDK-8361250 : [lworld] use more IRNode regexes in valhalla IR tests
  • Type: Bug
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: repo-valhalla
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2025-07-02
  • Updated: 2025-09-24
  • Resolved: 2025-07-10
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
repo-valhallaFixed
Related Reports
Blocks :  
Relates :  
Relates :  
Description
Valhalla regexes for IR allocations are still old-style: they try to find a reference to the type we are interested in, then skip possible spilling, and find the call to the allocation function. This is quite brittle as already noticed (and fixed) in JDK-8314999.

For instance, InlineTypeRegexes::ALLOC is "(.*precise compiler/valhalla/inlinetypes/MyValue.*\\R(.*(?i:mov|xorl|nop|spill).*\\R)*.*C2 Runtime new_instance" + END
Let's instead use the IRNode::ALLOC_OF that matches on the graph and so has no spilling problems.

Many other regexes could probably be replaced/subsumed by IRNode ones.
Comments
A pull request was submitted for review. Branch: lworld URL: https://git.openjdk.org/valhalla/pull/1503 Date: 2025-07-04 16:36:36 +0000
04-07-2025