JDK-8350478 : Glass refactoring follow-up
  • Type: Bug
  • Component: javafx
  • Sub-Component: window-toolkit
  • Affected Version: internal
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • OS: os_x
  • CPU: generic
  • Submitted: 2025-02-21
  • Updated: 2025-05-12
  • Resolved: 2025-05-12
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
internalFixed
Related Reports
Relates :  
JDK-8325379 - Refactor Glass classes to support both GL and Metal
Relates :  
JDK-8356758 - Check whether we need to set opaque flag in GlassWindow
Description
While refactoring Glass to work with MTL,ES2 & SW pipeline under https://bugs.openjdk.org/browse/JDK-8325379, 2 issues were noticed which can be updated in follow-up bug.

1) Remove references to CGLContextObj from GLassLayer3D
2) Check whether we need to set CAOpenGLLayer's opaque flag to the value of the NSWindow's opaque flag in GlassWindow.m. This flag was added under https://bugs.openjdk.org/browse/JDK-8095004 to fix issues in PickTest3D but in current code PickTest3D works properly without this code.
Comments
Changeset: 9ce61a3b Branch: metal Author: Jayathirth Rao D V <jdv@openjdk.org> Date: 2025-05-12 14:11:37 +0000 URL: https://git.openjdk.org/jfx-sandbox/commit/9ce61a3b6ee57c03a999a6770059bf4f387959c2
12-05-2025
Verified both Metal and OpenGL pipeline using Ensemble8 after removing CGLContextObj references from common code and it works fine.
12-05-2025
Regarding setting opaque flag in OpenGL pipeline. It is verified that without setting it also PickTest3D works fine now in OpenGL pipeline. Also this code is commented out even before JDK-8325379 glass refactoring. If we re-enable this code to set opaque flag on OpenGL pipeline code builds properly and also Ensemble8 works fine. But it needs more testing using CI. So i will create separate task to verify whether we need to set this flag or not. Another task of removing CGLContextObj references from common code will be take care under this bug.
12-05-2025