JDK-8346420 : Switch ignores default branch with JIT compilation
  • Type: Bug
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: 21.0.5
  • Priority: P4
  • Status: New
  • Resolution: Unresolved
  • Submitted: 2024-12-17
  • Updated: 2025-01-02
Description
ADDITIONAL SYSTEM INFORMATION :
Issue was reproduced on Linux x86, MacOS arm, Windows 10. Reproducible on Java 18-23.
e.g.:
openjdk version "21.0.5" 2024-10-15 LTS
OpenJDK Runtime Environment Temurin-21.0.5+11 (build 21.0.5+11-LTS)
OpenJDK 64-Bit Server VM Temurin-21.0.5+11 (build 21.0.5+11-LTS, mixed mode, sharing)


A DESCRIPTION OF THE PROBLEM :
ByteBuddy sporadically runs into an "impossible" exception in net.bytebuddy.dynamic.scaffold.TypeWriter.Default.ValidatingClassVisitor.visitField. This code path can happen just with switch statement skipping all branches including default. In general this condition is rare, but running org.example.App with -Xcomp reliably reproduces this condition on Java 18-23.

Exception in thread "main" java.lang.IllegalStateException: Field POOL_NORMAL defines an incompatible default value 0 at net.bytebuddy.dynamic.scaffold.TypeWriter$Default$ValidatingClassVisitor.visitField(TypeWriter.java:2535) at net.bytebuddy.dynamic.scaffold.TypeWriter$Default$ForInlining$WithFullProcessing$RedefinitionClassVisitor.onVisitField(TypeWriter.java:5164) at net.bytebuddy.utility.visitor.MetadataAwareClassVisitor.visitField(MetadataAwareClassVisitor.java:278) at net.bytebuddy.jar.asm.ClassVisitor.visitField(ClassVisitor.java:356) at net.bytebuddy.jar.asm.commons.ClassRemapper.visitField(ClassRemapper.java:169) at net.bytebuddy.jar.asm.ClassReader.readField(ClassReader.java:1138) at net.bytebuddy.jar.asm.ClassReader.accept(ClassReader.java:740) at net.bytebuddy.utility.AsmClassReader$Default.accept(AsmClassReader.java:132) at net.bytebuddy.dynamic.scaffold.TypeWriter$Default$ForInlining.create(TypeWriter.java:4039) at net.bytebuddy.dynamic.scaffold.TypeWriter$Default.make(TypeWriter.java:2246) at net.bytebuddy.dynamic.DynamicType$Builder$AbstractBase$UsingTypeWriter.make(DynamicType.java:4085) at net.bytebuddy.dynamic.DynamicType$Builder$AbstractBase.make(DynamicType.java:3769) at org.example.App.main(App.java:20)

REGRESSION : Last worked in version 17.0.13

STEPS TO FOLLOW TO REPRODUCE THE PROBLEM :
Provided in external source.

EXPECTED VERSUS ACTUAL BEHAVIOR :
EXPECTED -
Switch statement executing default branch
ACTUAL -
Switch statement skipping default branch and application running into an impossible condition.

---------- BEGIN SOURCE ----------
package org.example;
import net.bytebuddy.dynamic.scaffold.TypeValidation;
import net.bytebuddy.*;
import net.bytebuddy.dynamic.*;
public class App {

    private static final int POOL_NORMAL = 0;
    private static final int POOL_SUSPENDED = 1;
    private static final int POOL_SHUTDOWN = 2;

    public volatile int poolState;

    public static void main(String[] args) {
        System.out.println("Running on:"+System.getProperty("java.version"));
        DynamicType.Builder<App> builder = new ByteBuddy().with(TypeValidation.ENABLED)
                .redefine(App.class)
                .name(App.class.getName() + "_Redefine");
        for (int i = 0; i < 100; i++) {
            builder.make();
        }
    }
}
---------- END SOURCE ----------

FREQUENCY : rarely