JDK-8343630 : Pass AccessControlContext to/from WebKit as opaque object
  • Type: Bug
  • Component: javafx
  • Sub-Component: web
  • Affected Version: 8,jfx24
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2024-11-05
  • Updated: 2024-11-16
  • Resolved: 2024-11-08
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
jfx23.0.2Fixed
Related Reports
Blocks :  
Relates :  
Description
As a follow-on to removing security manager support, we are removing all references to the terminally deprecated AccessController and AccessControlConext classes. This is tracked by JDK-8342993.

The Java code passes an AccessControlConext instance to the native JSObject code, which stores it in the object so that it can later pass it back to the Utilities::fwkInvokeWithContext Java method via a JNI upcall. The native WebKit otherwise does not use the AccessControlConext object. Since it is already treated as an opaque object by the native code, the easiest path to eliminating the references to AccessControlConext is to change the method signatures to pass an Object rather than AccessControlConext. This has two related advantages:

1. It will minimize the changes to native WebKit JNI code.
2. It will allow us to keep the native code identical between mainline jfx24 and earlier releases (e.g., jfx23u, jfx21u, etc), since earlier releases still need to be able to run with a security manager.

This bug fix needs to go in ahead of the fix for JDK-8342993 and should be backported to all earlier code lines (whereas none of the other SM follow-up fixes can be backported).
Comments
A pull request was submitted for review. Branch: master URL: https://git.openjdk.org/jfx23u/pull/29 Date: 2024-11-14 00:34:26 +0000
14-11-2024

[jfx23u-fix-request] Approval Request from Kevin Rushforth Needed to keep native WebKit in sync.
14-11-2024

Changeset: fffa0fc4 Branch: master Author: Kevin Rushforth <kcr@openjdk.org> Date: 2024-11-08 16:58:40 +0000 URL: https://git.openjdk.org/jfx/commit/fffa0fc4fd0f2ac332ae616066579c3b6b5a9861
08-11-2024

A pull request was submitted for review. Branch: master URL: https://git.openjdk.org/jfx/pull/1626 Date: 2024-11-05 17:57:19 +0000
05-11-2024