JDK-8343148 : C2: Refactor uses of "PhaseValue::*con*() + PhaseIdealLoop::set_ctrl()" into separate method
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: 24
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2024-10-28
  • Updated: 2024-12-16
  • Resolved: 2024-12-11
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 25
25 b02Fixed
Related Reports
Duplicate :  
JDK-8343907 - C2: Constants without root as control in PhaseIdealLoop::split_thru_phi
Relates :  
JDK-8346184 - C2: assert(has_node(i)) failed during split if
Relates :  
JDK-8343907 - C2: Constants without root as control in PhaseIdealLoop::split_thru_phi
Relates :  
JDK-8343137 - C2: VerifyLoopOptimizations fails with "Was reachable in only one"
Description
There are many uses of:

node = intcon(x);
set_ctrl(node, C->root())

We should introduce a new method PhaseIdealLoop::intcon which is a wrapper that calls PhaseValue::intcon() and sets control to root. Then we do not need to worry about setting control which can easily be forgotten as for example in JDK-8343137.
Comments
Changeset: e88e793c Branch: master Author: theoweidmannoracle <theo.weidmann@oracle.com> Committer: Christian Hagedorn <chagedorn@openjdk.org> Date: 2024-12-11 07:52:06 +0000 URL: https://git.openjdk.org/jdk/commit/e88e793cfd9a5db8745aa187c2726ad029b60ab7
11-12-2024
A pull request was submitted for review. Branch: master URL: https://git.openjdk.org/jdk/pull/21836 Date: 2024-11-01 16:04:38 +0000
05-11-2024
Assigning this to [~thartmann] to reserve it as a starter task for a new hire starting in November.
28-10-2024