JDK-8342943 : Replace predicate walking and cloning code for main/post loops with a predicate visitor
  • Type: Sub-task
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: 24
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2024-10-24
  • Updated: 2025-01-07
  • Resolved: 2024-11-06
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 24
24 b23Fixed
Related Reports
Blocks :  
JDK-8342945 - Replace predicate walking code in get_assertion_predicates() used for Loop Unswitching and cleaning useless Template Assertion Predicates with a predicate visitor
Blocks :  
JDK-8341977 - Replace predicate walking and cloning code for Loop Peeling with a predicate visitor
Blocks :  
JDK-8342047 - Create Template Assertion Predicates with Halt nodes only instead of uncommon traps
Relates :  
JDK-8347018 - C2: assert(find_block_for_node(self->in(0)) == early) failed: The home of a memory writer must also be its earliest placement
Description
JDK-8340786 introduced a predicate iterator that work together with visitors. This task should replace the existing predicate walking code found for Loop Peeling with a new PredicateVisitor that uses the PredicateIterator class. In follow-up tasks, we can do the same replacement for Main/Post loops, Loop Unswitching/Removing useless assertion predicate and Loop Unrolling. 

Once these replacements are done, we can remove the UCTs for Template Assertion Predicates and fix the Template Assertion Predicate matching in a single place (i.e. TemplateAssertionPredicate::is_predicate()).
Comments
Changeset: 4431852a Branch: master Author: Christian Hagedorn <chagedorn@openjdk.org> Date: 2024-11-06 06:10:01 +0000 URL: https://git.openjdk.org/jdk/commit/4431852a880b06241231d346311170331c20ab2d
06-11-2024
A pull request was submitted for review. Branch: master URL: https://git.openjdk.org/jdk/pull/21790 Date: 2024-10-30 15:18:56 +0000
30-10-2024