JDK-8342583 : Few minor cleanups
  • Type: Sub-task
  • Component: javafx
  • Sub-Component: graphics
  • Affected Version: internal
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • OS: os_x
  • Submitted: 2024-10-18
  • Updated: 2024-10-18
  • Resolved: 2024-10-18
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
internalFixed
Description
- Remove unused variables

-- MTLGraphics
---- color and ignoreScissor from MTLGraphics.nClear() method

-- MetalContext
---- resourceFactory, rttCleared, rttLoadAction, tripleBufferSemaphore, MAX_QUADS_IN_A_BATCH
--------------------

- Use matrix_identity_float4x4 variable instead of creating an identity matrix manually.
- matrix_identity_float4x4 variable provided by Apple simd library:
https://developer.apple.com/documentation/accelerate/matrix_identity_float4x4?language=objc
--------------------

- Remove a warning
-- MetalShader.m
Add [super dealloc] call to remove a warning: MetalShader.m:458:1: warning: method possibly missing a [super dealloc] call [-Wobjc-missing-super-calls]
--------------------
Comments
Changeset: c5f9d25b Branch: metal Author: Ambarish Rapte <arapte@openjdk.org> Date: 2024-10-18 12:00:26 +0000 URL: https://git.openjdk.org/jfx-sandbox/commit/c5f9d25bb843a6affa933cf42ee67d7c517c8804
18-10-2024