JDK-8341411 : C2: remove slice parameter from GraphKit::make_load() and GraphKit::store_to_memory()
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: 24
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2024-10-02
  • Updated: 2025-03-27
  • Resolved: 2024-11-13
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 24
24 b24Fixed
Related Reports
Relates :  
JDK-8340214 - C2 compilation asserts with "no node with a side effect" in PhaseIdealLoop::try_sink_out_of_loop
Relates :  
JDK-8344116 - C2: remove slice parameter from LoadNode::make
Relates :  
JDK-8344124 - JDK-8341411 Broke the build
Relates :  
JDK-8344108 - [lworld] Merge of 8340214 causes "slice of address and input slice don't match" asserts
Description
Remove the slice argument from GraphKit::make_load() and GraphKit::store_to_memory() (and to their callers) given it's redundant with the address type and error prone.

See: https://github.com/openjdk/jdk/pull/21303
Comments
Note to backporters: this PR broke the build; fix is in JDK-8344124.
13-11-2024
Changeset: 8af304c6 Branch: master Author: theoweidmannoracle <theo.weidmann@oracle.com> Committer: Tobias Hartmann <thartmann@openjdk.org> Date: 2024-11-13 13:34:09 +0000 URL: https://git.openjdk.org/jdk/commit/8af304c60f2758b1a6c6fb53dee6bd66b3d4f6f0
13-11-2024
A pull request was submitted for review. Branch: master URL: https://git.openjdk.org/jdk/pull/21834 Date: 2024-11-01 14:50:31 +0000
05-11-2024
Assigning this to me to reserve for a new hire in the compiler team.
23-10-2024