JDK-8341044 : CDSPlugin.java fails to create compact object header CDS archives
  • Type: Bug
  • Component: hotspot
  • Sub-Component: runtime
  • Affected Version: repo-lilliput
  • Priority: P3
  • Status: Closed
  • Resolution: Not an Issue
  • Submitted: 2024-09-26
  • Updated: 2024-10-04
  • Resolved: 2024-10-04
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
repo-lilliputResolved
Related Reports
Blocks :  
Description
Project Lilliput adds 2 additional CDS archives, classes_coh.jsa and classes_nocoops_coh.jsa. The jlink CDSPlugin.java file only generates the first two archives. This causes failures in the CDSPluginTest.java.
Comments
This is fixed in the latest commit to the CompactObjectHeaders PR.
04-10-2024

[~rkennke] Try this patch to the test (better than the last thing I posted). Thanks to [~ccheung] for his slack advice. + WhiteBox wb = WhiteBox.getWhiteBox(); + boolean COMPACT_HEADERS = + Platform.is64bit() && wb.getBooleanVMFlag("UseCompactObjectHeaders") && wb.isDefaultVMFlag("UseCompactObjectHeaders"); + + String suffix = COMPACT_HEADERS ? "_coh.jsa" : ".jsa"; +
03-10-2024

It doesn't look like a fix for this issue to me. Note that the change in that patch fixed an earlier issue. It solved the problem when you have UseCompactObjectHeader on by default in the code. This bug talks about another issue that arise when you set UseCompactObjectHeader on the command line.
01-10-2024

https://github.com/openjdk/lilliput-jdk21u/pull/36/files Is this the fix to this in one of the Lilliput repos? Is this going to be the fix in the PR?
01-10-2024

My understanding was that there is an incompatibility between the shared archive being used and the use of the +UseCOH flag.
01-10-2024

I'm confused what we're looking for here. Maybe [~matsaave] has figured it out. I'll ask him.
01-10-2024