JDK-8340007 : Refactor KeyEvent/FunctionKeyTest.java
  • Type: Bug
  • Component: client-libs
  • Sub-Component: java.awt
  • Affected Version: 17.0.13,17.0.13-oracle,22
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2024-09-12
  • Updated: 2024-10-25
  • Resolved: 2024-09-19
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 11 JDK 17 JDK 21 JDK 23 JDK 24 JDK 8
11.0.26-oracleFixed 17.0.14-oracleFixed 21.0.6-oracleFixed 23.0.2Fixed 24 b17Fixed 8u441Fixed
Related Reports
Duplicate :  
Relates :  
Relates :  
Relates :  
Description
The java/awt/event/KeyEvent/FunctionKeyTest.java test can be improved:

The class FunctionKeyTester should be moved into FunctionKeyTest;
The constants in switch statement 403, 404 should be replaced with KEY_PRESSED and KEY_RELEASED which are more descriptive;
The `failures` field is of type StringBuilder which is not thread-safe, but it's accessed from two threads.
Comments
Fix request [17u,21u] I backport this for parity with 17.0.14-oracle,21.0.6-oracle. No risk, only a test change Clean backport. Test passes. SAP nightly testing passed.
08-10-2024

A pull request was submitted for review. Branch: master URL: https://git.openjdk.org/jdk17u-dev/pull/2945 Date: 2024-10-07 09:39:20 +0000
07-10-2024

A pull request was submitted for review. Branch: master URL: https://git.openjdk.org/jdk21u-dev/pull/1029 Date: 2024-10-07 09:39:02 +0000
07-10-2024

A pull request was submitted for review. Branch: master URL: https://git.openjdk.org/jdk23u/pull/105 Date: 2024-09-19 11:22:16 +0000
19-09-2024

Changeset: 2faf8b8d Branch: master Author: Alexey Ivanov <aivanov@openjdk.org> Date: 2024-09-19 09:44:57 +0000 URL: https://git.openjdk.org/jdk/commit/2faf8b8d582183275b1fdc92313a1c63c1753e80
19-09-2024

Fix Request for 23u This fix refactors the `java/awt/event/KeyEvent/FunctionKeyTest.java` test, it improves its readability and makes it somewhat quicker. The test passes successfully in (Oracle) CI. Risk: Low Pull request for jdk23u: https://github.com/openjdk/jdk23u/pull/105
19-09-2024

A pull request was submitted for review. Branch: master URL: https://git.openjdk.org/jdk/pull/21013 Date: 2024-09-16 09:55:19 +0000
16-09-2024