JDK-8334868 : Ensure CheckUninstallModalHook is called in WPageDialogPeer._show
  • Type: Bug
  • Component: client-libs
  • Sub-Component: java.awt
  • Affected Version: 8,11,17,21,23,24
  • Priority: P3
  • Status: Open
  • Resolution: Unresolved
  • Submitted: 2024-06-24
  • Updated: 2024-06-24
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
tbdUnresolved
Related Reports
Relates :  
JDK-8334509 - Cancelling PageDialog does not return the same PageFormat object
Description
During code review [1] for JDK-8334509, it was noticed the code at lines 695-707 is not executed if an error occurs.

> It does look odd. Focus would need transferring in both cases I'd expect.

AwtDialog::CheckInstallModalHook() is called right before the page dialog is displayed by using ::PageSetupDlg. So, AwtDialog::CheckUninstallModalHook() needs to be called after it.

[1] https://github.com/openjdk/jdk/pull/19786#discussion_r1645900131
[2] https://github.com/openjdk/jdk/blob/51b0abc87439014c4c5022c0057614f99a741ddd/src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp#L695-L707
Comments
A pull request was submitted for review. URL: https://git.openjdk.org/jdk/pull/19867 Date: 2024-06-24 20:16:30 +0000
24-06-2024