JDK-8334161 : Enable -Werror for javac tasks to fail on any warnings
  • Type: Bug
  • Component: javafx
  • Sub-Component: build
  • Affected Version: jfx23
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2024-06-12
  • Updated: 2024-07-12
  • Resolved: 2024-06-26
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
jfx23 b24Fixed
Related Reports
Blocks :  
JDK-8327255 - javac lint warnings: removal, missing-explicit-ctor
Blocks :  
JDK-8327170 - ☂ Enable and fix javac lint warnings
Relates :  
JDK-8334137 - Marlin: replace terminally deprecated sun.misc.Unsafe memory access methods
Description
After we have enabled a default set of lint options, and have no other javac warnings, we should enable -Werror when running javac. Currently we can't do that for all modules, because of the use of sun.misc.Unsafe by Marlin, so enabling this globally is blocked by JDK-8334137.

We can probably enable it for all other modules, and disable it just for graphics, and then enable it for graphics as part of JDK-8334137.
Comments
Changeset: 0d2a0a46 Author: Kevin Rushforth <kcr@openjdk.org> Date: 2024-06-26 18:51:51 +0000 URL: https://git.openjdk.org/jfx/commit/0d2a0a462e500b9bb7ac4fc4f45beff9a378ea60
26-06-2024
A pull request was submitted for review. URL: https://git.openjdk.org/jfx/pull/1475 Date: 2024-06-12 21:57:32 +0000
25-06-2024
I created a Draft PR that enables -Werror for all modules except javafx.graphics (because of the use of sun.misc.Unsafe in Marlin): https://github.com/openjdk/jfx/pull/1475 It depends on JDK-8327255, so once that is integrated, I'll merge master into my source branch and take the PR out of Draft.
12-06-2024