JDK-8331573 : Rename CollectedHeap::is_gc_active to be explicitly about STW GCs
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: gc
  • Affected Version: 17,21,22,23
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2024-05-02
  • Updated: 2024-05-31
  • Resolved: 2024-05-06
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 21 JDK 23
21.0.5Fixed 23 b22Fixed
Related Reports
Blocks :  
JDK-8331572 - Allow using OopMapCache outside of STW GC phases
Relates :  
JDK-8331721 - Introduce CollectedHeap helper methods for any GC in progress
Relates :  
JDK-8331719 - Cleanup asserts/code after introducing IsSTWGCActiveMark
Description
`CollectedHeap::is_gc_active()` is confusing, since its name implies any GC phase is running, while it actually only covers the STW GCs. It would be good to rename it for clarity. The freed-up name, `is_gc_active`, could then be repurposed to track any (concurrent or STW) GC phase running. That would be useful to resolve JDK-8331572.

Doing this rename separately guarantees we have caught and renamed all current uses.
Comments
[jdk21u-fix-request] Approval Request from Aleksey Shipilëv Unclean backport to avoid confusion on is_gc_active flag and provide grounds for future backports. JDK 21u code needs straight-forward adjustments. All tests pass.
30-05-2024
A pull request was submitted for review. URL: https://git.openjdk.org/jdk21u-dev/pull/609 Date: 2024-05-28 09:07:10 +0000
28-05-2024
Changeset: 1eec30a6 Author: Aleksey Shipilev <shade@openjdk.org> Date: 2024-05-06 11:17:39 +0000 URL: https://git.openjdk.org/jdk/commit/1eec30a6c03b7f4028405dc9bdb4d2a663b3987d
06-05-2024
A pull request was submitted for review. URL: https://git.openjdk.org/jdk/pull/19064 Date: 2024-05-02 14:40:35 +0000
02-05-2024