JDK-8330386 : Replace Opaque4Node of Initialized Assertion Predicate with new OpaqueInitializedAssertionPredicateNode
  • Type: Sub-task
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: 23
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2024-04-16
  • Updated: 2024-06-03
  • Resolved: 2024-05-28
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 23
23 b25Fixed
Related Reports
Relates :  
JDK-8333394 - C2: assert(bol->is_Opaque4() || bol->is_OpaqueInitializedAssertionPredicate()) failed: Opaque node of non-null-check or of Initialized Assertion Predicate
Relates :  
JDK-8333252 - C2: assert(assertion_predicate_has_loop_opaque_node(iff)) failed: must find OpaqueLoop* nodes
Description
Currently, a Template Assertion Predicate and an Initialized Assertion Predicate both use an Opaque4 node. They could also both use a Halt Node on the uncommon proj. To distinguish them, one need to find the OpaqueLoop* nodes. 

To simplify that, I introduce a new OpaqueInitializedAssertionPredicate node for Initialized Assertion Predicates. An additional benefit compared to Opaque4 nodes is that we do not need a second input to store the constant that's gonna be used for product builds - we implicitly know that the check is always true and can later replace it with a true constant.

I will not rename or refactor the usage of Opaque4 nodes here. I want to later replace the Template Assertion Predicate If nodes by a dedicated TemplateAssertionPredicateNode. Then we can get rid of the Opaque4 node for Assertion Predicates all together.
Comments
Changeset: 2edb6d98 Author: Christian Hagedorn <chagedorn@openjdk.org> Date: 2024-05-28 08:12:36 +0000 URL: https://git.openjdk.org/jdk/commit/2edb6d98133d8bd6dc4527c7497c460283fdc53e
28-05-2024
A pull request was submitted for review. URL: https://git.openjdk.org/jdk/pull/18951 Date: 2024-04-25 13:34:31 +0000
26-04-2024