JDK-8315589 : MSLBackend: Remove unrequired samplers from shaders
Type:Sub-task
Component:javafx
Sub-Component:graphics
Affected Version:internal
Priority:P4
Status:Resolved
Resolution:Fixed
OS:os_x
CPU:generic
Submitted:2023-09-04
Updated:2024-07-06
Resolved:2023-09-04
The Version table provides details related to the release that this issue/RFE will be addressed.
Unresolved : Release in which this issue/RFE will be addressed. Resolved: Release in which this issue/RFE has been resolved. Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.
Currently we create shaders by adding four samplers as arguments to all shader functions and all helper functions within a shader file.
These can be optimized a little by adding only required number of samplers.
Comments
This does not show any gain in FPS.
To compare the effect of this change. Compare the generated shaders before and after this change.
Changeset: 047da5df
Author: Ambarish Rapte <arapte@openjdk.org>
Date: 2023-09-04 10:32:13 +0000
URL: https://git.openjdk.org/jfx-sandbox/commit/047da5df0d65d866afc77b5749b9f7d07bb90dc2