JDK-8314597 : Deprecate for removal protected access methods in converters
  • Type: Bug
  • Component: javafx
  • Sub-Component: base
  • Affected Version: jfx17
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2023-08-18
  • Updated: 2023-12-08
  • Resolved: 2023-12-04
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
jfx22 b21Fixed
Related Reports
Blocks :  
JDK-8314590 - ☂ Eliminate all javadoc warnings in JavaFX
CSR :  
JDK-8320615 - Deprecate for removal protected access methods in converters
Relates :  
JDK-8260475 - Deprecate for removal protected access members in DateTimeStringConverter
Description
The protected method DateTimeStringConverter::getDateFormat was terminally deprecated in JavaFX 17 as part of JDK-8260475 and removed (by making it package-scope) in JavaFX 18 as part of JDK-8270838.

The getDateFormat method is overridden by the DateStringConverter and TimeStringConverter subclasses, and ideally should have been terminally deprecated and then removed at same time as the method in the base class.

We should correct that by terminally deprecating the overridden protected methods DateStringConverter::getDateFormat and TimeStringConverter::getDateFormat in JavaFX 22 and removing them (by making them package scope) in JavaFX 23.

I noticed this while looking at our existing javadoc warnings after bumping the warning limit to 1000. See JDK-8314590. Part of doing the deprecation should be to remove the now-erroneous "@inheritDoc" tag.

getNumberFormat() in NumberStringConverter (and subclasses) should also be terminally deprecated.
Comments
Changeset: 092d5d2d Author: Nir Lisker <nlisker@openjdk.org> Date: 2023-12-04 06:12:07 +0000 URL: https://git.openjdk.org/jfx/commit/092d5d2d03feaaf51254d1e0c40238574df72325
04-12-2023
A pull request was submitted for review. URL: https://git.openjdk.org/jfx/pull/1294 Date: 2023-11-21 21:11:43 +0000
21-11-2023
[~nlisker] I must have missed seeing your question. Expanding this bug to cover getNumberFormat in NumberStringConverter and its subclasses is a good idea.
21-11-2023
[~kcr] For this to go into 22, I will need to know what to do with the other fields I mentioned in the comment above.
21-11-2023
I can take it. I looked at the other converters a while back and I saw something similar in NumberStringConverter (and subclasses) with getNumberFormat(). Should this one also be removed?
20-08-2023
[~nlisker] would you mind taking this? I'll file the "remove" bug later.
18-08-2023