JDK-8314056 : Remove runtime platform check from frem/drem
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: 21,22
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • OS: generic
  • CPU: x86,x86_64
  • Submitted: 2023-08-09
  • Updated: 2023-11-09
  • Resolved: 2023-08-30
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 22
22 b13Fixed
Related Reports
Duplicate :  
Duplicate :  
Relates :  
Relates :  
Relates :  
Relates :  
Description
This fix adds about 4% performance by removing the runtime platform type check and moving code to stubGenerator.
Comments
Changeset: ce2a7ea4 Author: Scott Gibbons <sgibbons@openjdk.org> Committer: Jatin Bhateja <jbhateja@openjdk.org> Date: 2023-08-30 01:28:27 +0000 URL: https://git.openjdk.org/jdk/commit/ce2a7ea40a22c652e5f8559c91d5eea197e2d708
30-08-2023

This fix should resolve (or at least explain) the linked JBSs. The x87 code introduced by JDK-8302191 will now only run on non-AVX2 enabled machines, replaced by faster AVX2 / AVX512 code introduced by JDK-8308966. The performance drop seen in JDK-8312188 was introduced in JDK-8308966 and has been fixed in this commit. The performance seen in JDK-8312233 is an artifact of the values used in testing of the fmod/dmod as explained in the report, however the specific case will also be accelerated by this fix (i.e., the case where the numerator is smaller than the denominator in the modulus for the majority of operations). I am not familiar enough with the JBS resolution process to properly signify this relationship. I feel that all 4 of these linked issues should be resolved by this commit. I would appreciate any help to verify this conclusion and how to reflect it in the JBS system.
16-08-2023

A pull request was submitted for review. URL: https://git.openjdk.org/jdk/pull/15210 Date: 2023-08-09 16:48:36 +0000
09-08-2023