JDK-8313650 : Add hasProperties method to MenuItem and Toggle
  • Type: Enhancement
  • Component: javafx
  • Sub-Component: controls
  • Affected Version: jfx20
  • Priority: P4
  • Status: Open
  • Resolution: Unresolved
  • OS: generic
  • CPU: generic
  • Submitted: 2023-08-02
  • Updated: 2024-09-09
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
tbdUnresolved
Related Reports
CSR :  
JDK-8314593 - Add hasProperties method to MenuItem and Toggle
Relates :  
JDK-8313651 - Add 'final' keyword to public property methods in controls
Description
A DESCRIPTION OF THE PROBLEM :
Most JavaFX classes with properties have the hasProperties method, such as Node.hasProperties. But in MenuItem, it missing hasProperties method. And it also causes Toggle missing hasProperties method.
Comments
The PR has died. If noone objects, I think we should close this ticket as WON'T FIX
29-02-2024
A pull request was submitted for review. URL: https://git.openjdk.org/jfx/pull/1215 Date: 2023-08-18 17:06:57 +0000
18-08-2023
Right. For Dialog, one can argue that it would still be a beneficial method. But then there is Service, where I also don't know a usecase where we need properties. Although they do not harm and may give some flexibility. In any case, we should probably review if all classes that define a getProperties() method have a hasProperties() method.
03-08-2023
I agree with Andy. Adding it to the EventTarget interface doesn't seem right in any case.
02-08-2023
Re: EventTarget. Dialog does not have getProperties(), and probably there is no use case for it to have one, at least I can't think of any. Thank you for the suggestion though.
02-08-2023
Might be worth to add to the EventTarget interface. Almost all subclasses of EventTarget have a #getProperties() method.
02-08-2023
This is an RFE not a bug.
02-08-2023
Moving to JDK project for review.
02-08-2023