JDK-8311622 : Minor correction in MTLShader.m - avoiding for loops used for logging with #ifdefs
  • Type: Sub-task
  • Component: javafx
  • Sub-Component: graphics
  • Affected Version: internal
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • OS: os_x
  • CPU: generic
  • Submitted: 2023-07-07
  • Updated: 2023-07-07
  • Resolved: 2023-07-07
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
internalFixed
Description
In MTLShader.m, for loops are used to log data present in the fragArgIndicesDict.

These loops can be moved under #ifdef SHADER_VERBOSE.
Comments
Changeset: 41dd08d9 Author: aghaisas <ajitgh@gmail.com> Date: 2023-07-07 11:35:05 +0000 URL: https://git.openjdk.org/jfx-sandbox/commit/41dd08d936da2db7433a6c854bb31406bd49ca1b
07-07-2023
A minute performance gain is observed with this #ifdef addition- Without fix : --------------- RenderPerfTest -t LinGradCircle -n 500 ------- LinGradCircle (Objects Frames FPS), 500, 101, 10.084 RenderPerfTest -t RadGradCircle -n 500 ------- RadGradCircle (Objects Frames FPS), 500, 90, 8.986 With fix : ------------ RenderPerfTest -t LinGradCircle -n 500 ------- LinGradCircle (Objects Frames FPS), 500, 104, 10.383 RenderPerfTest -t RadGradCircle -n 500 ------- RadGradCircle (Objects Frames FPS), 500, 94, 9.347
07-07-2023