Bug ID: JDK-8307138 Fix signed integer overflow in compiler code

JDK-8307138 : Fix signed integer overflow in compiler code

Type: Bug
Component: hotspot
Sub-Component: compiler
Affected Version: 8-pool,11-pool,17,21

Priority: P4
Status: Resolved
Resolution: Delivered

Submitted: 2023-04-29
Updated: 2024-01-29
Resolved: 2023-12-14

Versions (Unresolved/Resolved/Fixed)

The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.

Other
tbdResolved

Related Reports

Blocks :	JDK-8233144 - undefined behavior: signed integer overflow
Duplicate :	JDK-8307230 - Fix signed overflow issues found with -ftrapv
Relates :	JDK-8306331 - assert((cnt > 0.0f) && (prob > 0.0f)) failed: Bad frequency assignment in if
Relates :	JDK-8324833 - Signed integer overflows in ABS

Sub Tasks

JDK-8307139 :	Fix signed integer overflow in compiler code, part 1 - Resolved
JDK-8308975 :	Fix signed integer overflow in compiler code, part 2 - Resolved
JDK-8310606 :	Fix signed integer overflow, part 3 - Resolved
JDK-8312077 :	Fix signed integer overflow, final part - Resolved

Description

There are multiple locations in the compiler code with signed overflows which is undefined behavior (compilers could use this undefined behavior for optimizations). We should check our code by configuring with --with-extra-cxx-flags='-ftrapv' and running some extensive testing with it. -ftrapv emits traps for signed additions, subtractions and multiplications. If there is an overflow, we abort.

Comments

Thanks Dean. Let's resolve as Delivered.
14-12-2023
[~thartmann], we can close this now. How do we do that, considering this is an umbrella issue with sub-tasks?
13-12-2023
[~dlong] Sounds good, thanks for the update.
12-06-2023
[~thartmann] The work is still ongoing. I'm only up to tier2.
07-06-2023
[~dlong] can we close this now?
07-06-2023
[~dlong] Sorry, I've missed that you have already filed this issue and its sub-task before filing JDK-8307230. I suggest to close this one and the sub-task as dup of JDK-8307230 and treat that one as umbrella issue to resolve all the issues together in one go.
02-05-2023
ILW = same as JDK-8233144 = P4
01-05-2023