JDK-8302004 : InlineTree should consult replay file in release build
  • Type: Bug
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: 20,21
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Submitted: 2023-02-07
  • Updated: 2023-03-28
  • Resolved: 2023-02-10
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 21
21 b10Fixed
Related Reports
Relates :  
JDK-8292561 - Make "ReplayCompiles" a diagnostic product switch
Description
JDK-8292561 changed JVM option ReplayCompiles from debug to product.  It effectively unlocks the feature ReplayCompiles in release build. 

Currently, InlineTree::should_inline() and InlineTree::should_not_inline() only read from replay files without the macro guard PRODUCT.  That's to say, HotSpot can't playback the exact inlining decisions from replay files in release build. 

I think we should build the logic unconditionally. More discussion are in JDK-8292561
Comments
Changeset: 5830c03e Author: Matthijs Bijman <mbijman@amazon.com> Committer: Paul Hohensee <phh@openjdk.org> Date: 2023-02-10 13:38:42 +0000 URL: https://git.openjdk.org/jdk/commit/5830c03e531f2c84c31a61cd49c40bb5e549a91d
10-02-2023
A pull request was submitted for review. URL: https://git.openjdk.org/jdk/pull/12492 Date: 2023-02-09 14:25:50 +0000
09-02-2023
ILW = incorrect inlining replay; product builds; no workaround = MMH = P3
07-02-2023