JDK-8298726 : (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds
Type:Enhancement
Component:core-libs
Sub-Component:java.nio
Priority:P3
Status:Resolved
Resolution:Fixed
Submitted:2022-12-14
Updated:2023-01-03
Resolved:2022-12-15
The Version table provides details related to the release that this issue/RFE will be addressed.
Unresolved : Release in which this issue/RFE will be addressed. Resolved: Release in which this issue/RFE has been resolved. Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.
Converting the last modified time to millisecond may truncate, better to use the FileTime.
Comments
I've restored the issue type to Enhancement as this is a quality of implementation issue rather than the a bug.
27-12-2022
Ah, I see. I assumed it hadn't been merged because it was waiting on approval, but apparently approvals aren't required until RDP2: https://openjdk.org/jeps/3#rdp-1
Thanks Andrew. It was actually removed yesterday. See Christoph's and my discussion above.
21-12-2022
Added the jdk20-fix-request label to go with the comment. I can't see it getting approved without that :)
21-12-2022
Hi Christoph, Great minds! I just created a PR for a backport to jdk20.
Update: Sounds good to me. I'll proceed if no one has objected by tomorrow.
20-12-2022
A pull request was submitted for review.
URL: https://git.openjdk.org/jdk20/pull/64
Date: 2022-12-20 17:29:30 +0000
20-12-2022
[~tsteele], in that case (Enhancement->Bug and P4->P3) , can you please also backport this to jdk20? I think it should be in there from the beginning then. Thanks.
Update: Just seen the jdk20 fix request comment. You can just do /backport jdk20 and integrate when everything is clean and green, without fix request labeling. (Unless anybody objects regarding the prio and type of this JBS item)
20-12-2022
[jdk17u, jdk20 fix request]
Backporting this change fixes the test failure described in JDK-8297275. The backport is clean. Risk is low; the change is simple and affects AIX and macos only.
The failing TCK test looks good on AIX and Macos.
20-12-2022
For the purposes of backporting, I am changing Enhancement->Bug and P4->P3. This change addresses an issue with a JCK test for us, so the fix is high priority. Thanks Alan!
20-12-2022
A pull request was submitted for review.
URL: https://git.openjdk.org/jdk17u-dev/pull/957
Date: 2022-12-20 15:30:32 +0000