JDK-8295754 : PaginationSkin: memory leak when changing skin
  • Type: Bug
  • Component: javafx
  • Sub-Component: controls
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2022-10-20
  • Updated: 2022-12-10
  • Resolved: 2022-11-30
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
openjfx20 b10Fixed
Related Reports
Blocks :  
JDK-8241364 - ☂ Cleanup skin implementations to allow switching
Relates :  
JDK-8294809 - ListenerHelper for managing and disconnecting listeners
Relates :  
JDK-8290844 - Add Skin.install() method
Description
as determined by SkinMemoryLeakTest (remove line 171) and a leak tester 
https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java

Make sure to configure the current test in LeakTest:
protected final Type WE_ARE_TESTING = Type.PAGINATION;

Found another issue: Pagination class does not survive replacing its skin (all components disappear).

caused by:
- adding and not removing listeners
- adding and not removing children Nodes
- setting control's properties in the constructor
- incorrectly setting a clip rectangle

NOTE: the fix requires both ListenerHelper JDK-8294809 and Skin.install() JDK-8290844 changes.
Comments
Changeset: 0a785ae0 Author: Andy Goryachev <angorya@openjdk.org> Date: 2022-11-30 16:10:13 +0000 URL: https://git.openjdk.org/jfx/commit/0a785ae036f48c736b65df865a3b93f954d46fe5
30-11-2022
A pull request was submitted for review. URL: https://git.openjdk.org/jfx/pull/925 Date: 2022-10-20 20:48:07 +0000
28-11-2022