JDK-8295531 : ComboBoxBaseSkin: memory leak when changing skin
  • Type: Bug
  • Component: javafx
  • Sub-Component: controls
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2022-10-18
  • Updated: 2022-12-10
  • Resolved: 2022-12-06
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
openjfx20 b11Fixed
Related Reports
Blocks :  
JDK-8294809 - ListenerHelper for managing and disconnecting listeners
Blocks :  
JDK-8290844 - Add Skin.install() method
Blocks :  
JDK-8241364 - ☂ Cleanup skin implementations to allow switching
Description
as determined by SkinMemoryLeakTest (remove line 166) and a leak tester 
https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java

Affected skins:
- ColorPicker
- DatePicker
- ComboBox

caused by:
- out-of-order modification of the control property (skin.install)
- adding skin nodes and not removing them in dispose()
- adding listeners and not removing them in dispose()

NOTE: the fix will require not only ListenerHelper JDK-8294809 but also Skin.install() JDK-8290844 changes.
Comments
Changeset: bb139208 Author: Andy Goryachev <angorya@openjdk.org> Date: 2022-12-06 16:27:38 +0000 URL: https://git.openjdk.org/jfx/commit/bb139208222d7c045be0a3c6f07ef15edcb1625b
06-12-2022
A pull request was submitted for review. URL: https://git.openjdk.org/jfx/pull/922 Date: 2022-10-18 23:41:05 +0000
28-11-2022