JDK-8294399 : (ch) Refactor some methods out of sun.nio.ch.UnixFileDispatcherImpl
  • Type: Enhancement
  • Component: core-libs
  • Sub-Component: java.nio
  • Affected Version: 20
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • OS: linux,os_x,aix
  • Submitted: 2022-09-26
  • Updated: 2025-07-02
  • Resolved: 2022-10-27
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 20
20 b22Fixed
Related Reports
Relates :  
JDK-8293331 - Refactor FileDispatcherImpl into operating system-specific components
Description
UnixFileDispatcherImpl contains close0(), dup0(), and preClose0() native methods which are commented as:

// Shared with SocketDispatcher and DatagramDispatcher but
// NOT used by FileDispatcherImpl

These should be moved to a place more appropriate for SocketDispatcher and DatagramDispatcher. UnixFileDispatcherImpl also contains preClose() and dup() methods which are not called anywhere hence could be removed.
Comments
[17u fix-no] I don't see why we should backport this to 17. No reason given, no risk assessment, no testing.
02-07-2025
[jdk17u-fix-request] Approval Request from Shruthi the backport fix. The `FileDispatcherImpl` class includes native methods close0(), dup0(), and preClose0(), which are commented as: >// Shared with SocketDispatcher and DatagramDispatcher but NOT used by FileDispatcherImpl These methods are being relocated to a new class, `UnixDispatcher`, which is referenced by both `SocketDispatcher` and `DatagramDispatcher`, where the methods are actually used. Additionally, the `FileDispatcherImpl` class contains preClose() and dup() methods that are not invoked anywhere and can therefore be safely removed.
02-07-2025
A pull request was submitted for review. Branch: master URL: https://git.openjdk.org/jdk17u-dev/pull/3631 Date: 2025-06-11 14:08:10 +0000
11-06-2025
Changeset: d6678952 Author: Brian Burkhalter <bpb@openjdk.org> Date: 2022-10-27 15:35:24 +0000 URL: https://git.openjdk.org/jdk/commit/d6678952a6de4e5435dab65e7029021832454857
27-10-2022
A pull request was submitted for review. URL: https://git.openjdk.org/jdk/pull/10434 Date: 2022-09-26 21:48:57 +0000
26-09-2022