JDK-8289384 : Fix warnings: method does not override the inherited method since it is private to a different package
  • Type: Bug
  • Component: javafx
  • Sub-Component: build
  • Priority: P4
  • Status: Closed
  • Resolution: Won't Fix
  • Submitted: 2022-06-28
  • Updated: 2022-08-03
  • Resolved: 2022-08-03
Related Reports
Blocks :  
Description
Eclipse Version 2022-06 (4.24.0) reports this warning in the following places:

```
The method ControlHelper.superProcessCSSImpl(Node) does not override the inherited method from ParentHelper since it is private to a different package	ControlHelper.java	line 62	/controls/src/main/java/com/sun/javafx/scene/control
The method CurveFittedAreaChart.getDataSize() does not override the inherited method from XYChart<Number,Number> since it is private to a different package	CurveFittedAreaChart.java	line 64	/samples/Ensemble8/src/samples/java/ensemble/samples/charts/area/curvefitted
The method CustomTransfer.checkByteArray(Object) does not override the inherited method from ByteArrayTransfer since it is private to a different package	CustomTransfer.java	line 80	/swt/src/main/java/javafx/embed/swt
The method D3DGraphics.getContext() does not override the inherited method from BaseShaderGraphics since it is private to a different package	D3DGraphics.java	line 81	/graphics/src/main/java/com/sun/prism/d3d
The method LabelSkinTest.LabelSkinMock.updateDisplayedText() does not override the inherited method from LabeledSkinBase<Label> since it is private to a different package	LabelSkinTest.java	line 2122	/controls/src/test/java/test/javafx/scene/control/skin
The method PopupControl.CSSBridgeHelper.superProcessCSSImpl(Node) does not override the inherited method from ParentHelper since it is private to a different package	PopupControl.java	line 1229	/controls/src/main/java/javafx/scene/control
The method ProgressIndicatorSkinTest.ProgressIndicatorSkinMock.getProgressColor() does not override the inherited method from ProgressIndicatorSkin since it is private to a different package	ProgressIndicatorSkinTest.java	line 82	/controls/src/test/java/test/javafx/scene/control/skin
The method TextFlow.computeChildPrefAreaHeight(Node, Insets) does not override the inherited method from Region since it is private to a different package	TextFlow.java	line 640	/graphics/src/main/java/javafx/scene/text
The method TextFlow.computeChildPrefAreaWidth(Node, Insets) does not override the inherited method from Region since it is private to a different package	TextFlow.java	line 622	/graphics/src/main/java/javafx/scene/text
```

Comments
Multiple reviewers expressed a doubt that fixing this warning adds any value. Even though I disagree - refactoring the code to avoid name collisions and possible confusion is a good thing (tm) - I think we can cancel this ticket, as the warning can be disabled in eclipse.
03-08-2022

A pull request was submitted for review. URL: https://git.openjdk.org/jfx/pull/824 Date: 2022-07-08 21:37:47 +0000
08-07-2022