JDK-8284102 : [TESTBUG] [11u] Retroactively add regression test for JDK-8272124
  • Type: Bug
  • Component: core-svc
  • Affected Version: 11.0.16
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • OS: linux
  • Submitted: 2022-03-31
  • Updated: 2022-12-19
  • Resolved: 2022-04-29
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 11 Other
11.0.16 b01Fixed openjdk8u372Fixed
Related Reports
Relates :  
JDK-8239559 - Cgroups: Incorrect detection logic on some systems
Relates :  
JDK-8254001 - [Metrics] Enhance parsing of cgroup interface files for version detection
Description
This is a JDK 11u only bug as JDK-8272124 got backported to 11u, but without the regression test which is in JDK 17.0.2+

Since OpenJDK 11u will get the cgroups v2 patches backported to 11.0.16, we should add the test as relevant infrastructure will be there.

Getting the test added depends on JDK-8239559 and JDK-8254001 to be in 11u as well.
Comments
Fix request (8u) Please consider this for 8u's cgroups v2 support. It's a test-only change. Not clean: needed Files.writeString→write for jdk8u adjustment. Thanks
19-12-2022
A pull request was submitted for review. URL: https://git.openjdk.org/jdk8u-dev/pull/179 Date: 2022-11-16 11:05:10 +0000
16-11-2022
Changeset: 245e2f2d Author: Severin Gehwolf <sgehwolf@openjdk.org> Date: 2022-04-29 16:44:36 +0000 URL: https://git.openjdk.java.net/jdk11u/commit/245e2f2da0302c9354255219248c2f6793947a6a
04-05-2022
Changeset: 245e2f2d Author: Severin Gehwolf <sgehwolf@openjdk.org> Date: 2022-04-29 16:44:36 +0000 URL: https://git.openjdk.java.net/jdk11u-dev/commit/245e2f2da0302c9354255219248c2f6793947a6a
29-04-2022
Hi [~sgehwolf], please add [11u] to the bug title. Thanks.
29-04-2022
Fix Request (OpenJDK 11u): This adds a regression test for JDK-8272124 backported in 11.0.13, but the test got dropped as required infra wasn't there (at the time). That has changed with the cgroups v2 backports. Should just add stability and will avoid potential regressions in that area. Test only change. Reviewed by Andrew Hughes. Test passes (and fails without the relevant fix). Depends on JDK-8254001 getting approved too, which is part of the cgroups v2 backport effort.
28-04-2022
A pull request was submitted for review. URL: https://git.openjdk.java.net/jdk11u-dev/pull/1056 Date: 2022-04-28 09:37:44 +0000
28-04-2022
Test correctly fails with this revert: diff --git a/src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemFactory.java b/src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemFactory.java index 0d8a5d181ac..931d0896079 100644 --- a/src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemFactory.java +++ b/src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemFactory.java @@ -194,10 +194,9 @@ public class CgroupSubsystemFactory { if (isCgroupsV2) { action = (tokens -> setCgroupV2Path(infos, tokens)); } - // The limit value of 3 is because /proc/self/cgroup contains three - // colon-separated tokens per line. The last token, cgroup path, might - // contain a ':'. - selfCgroupLines.map(line -> line.split(":", 3)).forEach(action); + selfCgroupLines.map(line -> line.split(":")) + .filter(tokens -> (tokens.length >= 3)) + .forEach(action); } Passes with the fix. Branch: https://github.com/jerboaa/jdk11u-dev/tree/jdk-8284102-add-reg-test
14-04-2022
https://github.com/openjdk/jdk/commit/4d6593ce0243457e7431a5990957a8f880e0a3fb#diff-56714e8f9b126ae2944f6afb93cd9d9a44d499a976c8ea7389e921e645823157 is the hunk to be added with this.
31-03-2022