JDK-8283246 : WebKit fails to build on Linux
  • Type: Bug
  • Component: javafx
  • Sub-Component: web
  • Priority: P4
  • Status: Closed
  • Resolution: Duplicate
  • OS: linux
  • CPU: x86_64
  • Submitted: 2022-03-16
  • Updated: 2022-03-16
  • Resolved: 2022-03-16
Related Reports
Duplicate :  
Description
WebKit fails to build on Linux after the 613.1 update:

jfx/modules/javafx.web/src/main/native/Source/WTF/wtf/linux/MemoryPressureHandlerLinux.cpp:39:28: error: ‘LogMemoryPressure’ was not declared in this scope; did you mean ‘isUnderMemoryPressure’?
   39 | #define LOG_CHANNEL_PREFIX Log
      |                            ^~~
jfx/modules/javafx.web/src/main/native/Source/WTF/wtf/Assertions.h:175:63: note: in definition of macro ‘JOIN_LOG_CHANNEL_WITH_PREFIX_LEVEL_2’
  175 | #define JOIN_LOG_CHANNEL_WITH_PREFIX_LEVEL_2(prefix, channel) prefix ## channel
      |                                                               ^~~~~~
jfx/modules/javafx.web/src/main/native/Source/WTF/wtf/Assertions.h:172:27: note: in expansion of macro ‘JOIN_LOG_CHANNEL_WITH_PREFIX’
  172 | #define LOG_CHANNEL(name) JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, name)
      |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
jfx/modules/javafx.web/src/main/native/Source/WTF/wtf/Assertions.h:172:56: note: in expansion of macro ‘LOG_CHANNEL_PREFIX’
  172 | #define LOG_CHANNEL(name) JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, name)
      |                                                        ^~~~~~~~~~~~~~~~~~
jfx/modules/javafx.web/src/main/native/Source/WTF/wtf/Assertions.h:495:35: note: in expansion of macro ‘LOG_CHANNEL’
  495 | #define LOG(channel, ...) WTFLog(&LOG_CHANNEL(channel), __VA_ARGS__)
      |                                   ^~~~~~~~~~~
jfx/modules/javafx.web/src/main/native/Source/WTF/wtf/linux/MemoryPressureHandlerLinux.cpp:74:9: note: in expansion of macro ‘LOG’
   74 |         LOG(MemoryPressure, "System is no longer under memory pressure.");
      |         ^~~
ninja: build stopped: subcommand failed.
Comments
Yes, I was doing a debug build. I didn't try production build but it makes sense that it is unaffected since LOG is probably a no-op there. I've changed the PR title.
16-03-2022

The file wtf/linux/MemoryPressureLinux.cpp was renamed wtf/unix/MemoryPressureUnix.cpp in https://trac.webkit.org/changeset/261428 . In the openjfx workspace, both files are present.
16-03-2022

[~peterz] I presume you mean that the DEBUG build fails on Linux (the production build works fine)? This is a duplicate of JDK-8270867. I'll comment in the PR: Please change the bug ID and title of your PR to JDK-8270867.
16-03-2022