JDK-8281122 : [IR Framework] Cleanup IR matching code in preparation for JDK-8280378
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: 17,19
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2022-02-02
  • Updated: 2023-01-02
  • Resolved: 2022-03-03
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 17 JDK 19
17.0.7-oracleFixed 19 b13Fixed
Related Reports
Relates :  
Relates :  
Description
The current implementation of the IRMatcher class makes it difficult to add IR matching on different compile phases (JDK-8280378). There is a lack of separation of concerns. Multiple things are tightly mixed together:
- IR encoding parsing
- hotspot_pid* file parsing
- IR matching
- IR annotation format checking
- Failure reporting

This RFE splits the single IRMatcher class into multiple classes to separate different phases (parsing, matching, reporting) and better structure the involved components (methods, rules, IR annotation attributes and its contraints etc.). This should make it easier to implement JDK-8280378 and possibly more IR matching features in the future.
Comments
Fix request [17u] I backport this for parity with 17.0.7-oracle. No risk, only a test change. A simple resolve was needed. Tests pass. SAP nightly testing passed.
30-12-2022

A pull request was submitted for review. URL: https://git.openjdk.org/jdk17u-dev/pull/995 Date: 2022-12-29 10:00:12 +0000
29-12-2022

Changeset: 2da67779 Author: Christian Hagedorn <chagedorn@openjdk.org> Date: 2022-03-03 07:17:56 +0000 URL: https://git.openjdk.java.net/jdk/commit/2da677793f562236d473afe12b5c941f25f41377
03-03-2022

A pull request was submitted for review. URL: https://git.openjdk.java.net/jdk/pull/7533 Date: 2022-02-18 13:36:31 +0000
18-02-2022