JDK-8280932 : G1: Rename HeapRegionRemSet::_code_roots accessors
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: gc
  • Priority: P4
  • Status: New
  • Resolution: Unresolved
  • Submitted: 2022-01-31
  • Updated: 2022-01-31
Related Reports
Relates :  
Description
JDK-8035406 renamed `_strong_code_roots_list` -> `_code_roots` in `HeapRegionRemSet`, but its relevant accessors still keep the "strong" prefix, e.g. `add_strong_code_root`.

Such inconsistency can cause some rather odd code, e.g. in `G1ScanCollectionSetRegionClosure`:

```
r->strong_code_roots_do(_pss->closures()->weak_codeblobs());
```

applying the weak closure on strong roots.

Drop the "strong" prefix to reconcile the names of the field and its accessors .

Comments
A pull request was submitted for review. URL: https://git.openjdk.java.net/jdk/pull/7285 Date: 2022-01-31 09:31:38 +0000
31-01-2022