JDK-8272735 : Add missing SubL node transformations
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: 18
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2021-08-19
  • Updated: 2023-02-08
  • Resolved: 2022-03-14
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 19
19 b14Fixed
Related Reports
Relates :  
JDK-8267265 - Use new IR Test Framework to create tests for C2 Ideal transformations
Description
- AddINode:

The check on line 285 (https://github.com/openjdk/jdk/blob/04a806ec86a388b8de31d42f904c4321beb69e14/src/hotspot/share/opto/addnode.cpp#L285) prevents the transformations on lines 305 (https://github.com/openjdk/jdk/blob/04a806ec86a388b8de31d42f904c4321beb69e14/src/hotspot/share/opto/addnode.cpp#L305) and 310 (https://github.com/openjdk/jdk/blob/04a806ec86a388b8de31d42f904c4321beb69e14/src/hotspot/share/opto/addnode.cpp#L310) from happening.

- AddLNode:

The check on line 467 (https://github.com/openjdk/jdk/blob/04a806ec86a388b8de31d42f904c4321beb69e14/src/hotspot/share/opto/addnode.cpp#L467) prevents the transformations on lines 492 (https://github.com/openjdk/jdk/blob/04a806ec86a388b8de31d42f904c4321beb69e14/src/hotspot/share/opto/addnode.cpp#L492) and 487 (https://github.com/openjdk/jdk/blob/04a806ec86a388b8de31d42f904c4321beb69e14/src/hotspot/share/opto/addnode.cpp#L487) from happening.

- SubNode:

Should the check on line 64 (https://github.com/openjdk/jdk/blob/04a806ec86a388b8de31d42f904c4321beb69e14/src/hotspot/share/opto/subnode.cpp#L64) be adjusted to account for "long" type?

- SubLNode

The transformation "(x-y) - x" present on SubINode (https://github.com/openjdk/jdk/blob/04a806ec86a388b8de31d42f904c4321beb69e14/src/hotspot/share/opto/subnode.cpp#L229) is missing from SubLNode.
Comments
Changeset: 5f3d4032 Author: Ahmed Muhsin <ahmedmuhsin@microsoft.com> Committer: Christian Hagedorn <chagedorn@openjdk.org> Date: 2022-03-14 09:05:53 +0000 URL: https://git.openjdk.java.net/jdk/commit/5f3d4032f3a8854f7afde28698e66a7b6684aed7
14-03-2022
A pull request was submitted for review. URL: https://git.openjdk.java.net/jdk/pull/7669 Date: 2022-03-02 21:28:13 +0000
03-03-2022
Moved it to tbd for now as the fork is coming up next Thursday. If you still want to bring it in before, please re-target it again to 18.
30-11-2021
Hi [~cslucas], as the fork's soon coming up in early December, are you planning to get this done in 18? Otherwise, it needs to be deferred to 19 once RDP 1 starts (because it's an RFE).
16-11-2021
I'm changing this into a performance RFE as the optimizations are just not optimal and might be blocked/missing.
03-11-2021
Fixed the links to point to actual URLs.
21-08-2021
Was split from the PR of JDK-8267265 to handle it separately.
20-08-2021
[~cslucas] Could you please replace the use of "shorturl.at" with the actual URLs?
19-08-2021
ILW = missing optimization = MMH = P3
19-08-2021