JDK-8270855 : Remove deprecated protected access members from DateTimeStringConverter
  • Type: CSR
  • Component: javafx
  • Sub-Component: base
  • Priority: P4
  • Status: Closed
  • Resolution: Approved
  • Fix Versions: openjfx18
  • Submitted: 2021-07-16
  • Updated: 2021-07-19
  • Resolved: 2021-07-19
Related Reports
CSR :  
Description
Summary
-------

DateTimeStringConverter contains members that were deprecated for removal in a previous version. They are removed in the current version.

Problem
-------

DateTimeStringConverter contains members that were deprecated for removal in a previous version.

Solution
--------

Remove them in the current version.

Specification
-------------

    diff --git a/modules/javafx.base/src/main/java/javafx/util/converter/DateTimeStringConverter.java b/modules/javafx.base/src/main/java/javafx/util/converter/DateTimeStringConverter.java
    index ae18858310..41b06ea361 100644
    --- a/modules/javafx.base/src/main/java/javafx/util/converter/DateTimeStringConverter.java
    +++ b/modules/javafx.base/src/main/java/javafx/util/converter/DateTimeStringConverter.java
    @@ -44,37 +44,15 @@
     
         // ------------------------------------------------------ Private properties
     
    -    /**
    -     * @deprecated This field was exposed erroneously and will be removed in a future version.
    -     */
    -    @Deprecated(forRemoval = true, since = "17")
    -    protected final Locale locale;
    +    final Locale locale;
     
    -    /**
    -     * @deprecated This field was exposed erroneously and will be removed in a future version.
    -     */
    -    @Deprecated(forRemoval = true, since = "17")
    -    protected final String pattern;
    +    final String pattern;
     
    -    /**
    -     * @deprecated This field was exposed erroneously and will be removed in a future version.
    -     */
    -    @Deprecated(forRemoval = true, since = "17")
    -    protected final DateFormat dateFormat;
    +    final DateFormat dateFormat;
     
    -    /**
    -     * @deprecated This field was exposed erroneously and will be removed in a future version.
    -     * @since JavaFX 8u40
    -     */
    -    @Deprecated(forRemoval = true, since = "17")
    -    protected final int dateStyle;
    +    final int dateStyle;
     
    -    /**
    -     * @deprecated This field was exposed erroneously and will be removed in a future version.
    -     * @since JavaFX 8u40
    -     */
    -    @Deprecated(forRemoval = true, since = "17")
    -    protected final int timeStyle;
    +    final int timeStyle;
     
     
         // ------------------------------------------------------------ Constructors
    @@ -218,11 +196,8 @@ public DateTimeStringConverter(DateFormat dateFormat) {
          *
          * @return a {@code DateFormat} instance for formatting and parsing in this
          * {@link StringConverter}
    -     *
    -     * @deprecated This method exposes internal implementation details and will be removed in a future version.
          */
    -    @Deprecated(forRemoval = true, since = "17")
    -    protected DateFormat getDateFormat() {
    +    DateFormat getDateFormat() {
             DateFormat df = null;
     
             if (dateFormat != null) {


Comments
Approving amended request.
19-07-2021

Thanks. That looks better.
19-07-2021

Updated
19-07-2021

[~nlisker], in the specification section, please show what API was removed (e.g. in diff format).
18-07-2021

Moving to Provisional.
16-07-2021