JDK-8267138 : Stray suffix when starting gtests via GTestWrapper.java
  • Type: Bug
  • Component: hotspot
  • Sub-Component: test
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2021-05-14
  • Updated: 2022-10-28
  • Resolved: 2021-06-25
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 17 JDK 18
17.0.6Fixed 18 b04Fixed
Related Reports
Relates :  
JDK-8264408 - test_oopStorage no longer needs to disable some tests on WIN32
Relates :  
JDK-8185734 - [Windows] Structured Exception Catcher missing around gtest execution
Description
For JDK-8185734: "[Windows] Structured Exception Catcher missing around gtest execution", I specified that  --gtest_catch_exceptions=0 should be specified to leave signal handling to the VM. This was needed to prevent the gtest runner from catching the stack-based SEH exceptions bubbling up from the tested VM, and leave them to our upstairs gtest runner wrapper  to catch.

However, there is a typo:
```
--gtest_catch_exceptions=0test_result.xml
```

Unless I am mistaken, it did not seem to have impeded Windows gtests. So maybe the gtest runner does a prefix match only. But this should be fixed.
Comments
Fix Request: Would like to have this in JDK17 to make gtest execution more stable on windows. Applies cleanly; risk is minimal.
25-10-2022
A pull request was submitted for review. URL: https://git.openjdk.org/jdk17u-dev/pull/822 Date: 2022-10-24 10:11:33 +0000
24-10-2022
Changeset: b565459f Author: Thomas Stuefe <stuefe@openjdk.org> Date: 2021-06-25 16:33:19 +0000 URL: https://git.openjdk.java.net/jdk/commit/b565459f83b749a01d7d873a01bb7dbdf55745de
25-06-2021