JDK-8265197 : Provide more default IR regexes
  • Type: Sub-task
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: 17
  • Priority: P4
  • Status: Open
  • Resolution: Unresolved
  • Submitted: 2021-04-14
  • Updated: 2022-06-07
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
tbdUnresolved
Description
The IRNode class provides some default regexes for commonly used IR nodes. This could be improved to support more default IR nodes as standalone or as composite regexes (for example, for various vector nodes, their sizes etc.). Depending on the type of IR node it is either easier to do the matching on PrintIdeal or PrintOptoAssembly.

Justification: Try to find existing tests that could use the IR test framework with the new default IR regexes or write new tests for existing optimizations that benefit from the new regexes.

Testing: The default regexes should be tested at least with a working and a failing example
Comments
Thanks for the update.
07-06-2022
That makes total sense. Thanks for clarifying. I'll unassign this from me because I'm not having time to work on this and I don't want to keep preventing others from taking it.
03-06-2022
Hi [~cslucas], I think this was more of an umbrella RFE. By now we have probably covered quite some nodes. But maybe at some day we just want to add regexes for all the current IR nodes. This could become even more interesting, once JDK-8280378 is in because there you need to think about which node is valid in which phase (the moment an IGV graph is printed). For example, a CountedLoopNode will not be found before PHASE_AFTER_CLOOPS.
03-06-2022
@chagedorn - do you think there is still work to be done here?
02-06-2022